Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image component to better handle positioning in Safari #564

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

K0rdan
Copy link
Member

@K0rdan K0rdan commented Jan 18, 2023

⚠ PLEASE DO NOT DELETE THE TEXT BELOW ⚠

Pull request's description

Add here a description of the modifications you made.

Checklist before merging (please do not edit)

You must review you work before to submit the review to others.

Self-review of your content

Remember the content must be readable and understandable by someone else than yourself.

  • From a technical point of view.
  • From a grammatical point of view (spelling mistakes, typos, clarity, etc.), and following the guidelines at the bottom.

External reviews of your content

  • You requested a technical review.
  • You requested a grammatical review.
  • You validated with @K0rdan or @alexgeron-Luos that it is safe to merge.

Some guidelines to keep in mind

  • Colons (:), semi-colons (;), exclamation (!), and interrogation points (?) are not preceded by a space (like full stops and commas). E.g.: Colons!

  • File names and/or address are put in italic. E.g.: The file main.c.

  • Functions, variables, or more generally short codes are put between grave accents. E.g.: To obtain code(), type `code()`.

  • Long codes are put into blocks of code with three grave accent on each side, and the language's name:

    ```c

    // Some C language

    ```

  • "Luos engine" has a upper case on the L for "Luos" and lower case on the e for "engine".

  • We call it "Luos engine" as a proper name, and not "the Luos engine".

  • Following that fashion, anything that's owned by "Luos engine" implies that we must use 's as the standard English rule to show the possessive case, e.g. "Luos engine's API".

  • The names pipe, gate, inspector, sniffer, app or application, driver, etc. have a lower case and can be refereed with the determiner the. E.g.: The inspector.

@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
documentation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 19, 2023 at 3:54PM (UTC)

@lorenzi-nicolas
Copy link
Contributor

@K0rdan Okay for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants