fix: add uniqueOperation params for new departments api #3331
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanBeaurepaire
added
the
🔖🐛 FIX
| @@ -44,6 +44,10 @@ export class LuDepartmentFeederComponent extends ALuTreeOptionOperator<ILuDepart | |||
| this._service.filters = filters ?? []; | |||
| } | |||
|
|
|||
| @Input() set uniqueOperation(uniqueOperation: number) { | |||
There was a problem hiding this comment.
Il faudrait pas que ce soit nullable pour pas faire de breaking ?
There was a problem hiding this comment.
L'input n'est pas marqué comme required donc l'attribut du composant n'est pas obligatoire. Pas de breaking
JeanBeaurepaire
force-pushed
the
add-missing-uniqueOperation-field
branch
from
ceb69ec to
44420be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing uniqueOperation for new api departments
https://github.com/LuccaSA/Organization.Structure/blob/81b1399a45228ba73d6eecd6177268065792bc16/back/src/Organization.Structure.Web/Controllers/Departments/TreeController.cs#L33
Optionally, technical or more in-depth description for reviewers.
Keep an empty line under your text, as well as the 5 lines that follow it.