Make enter key submit forms selectively #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzliedke
reviewed
Dec 15, 2016
| blur = true; | ||
| inputBinding.locationNameInput.on("keypress", function(e){ | ||
| if (!e.originalEvent) { return; } | ||
| if ((e.keyCode === 13 || e.keyCode == 9)){ |
There was a problem hiding this comment.
This line doesn't need the extra indentation. :)
As discussed a couple of years ago on issue #2, whenever pressing enter to select from the autocomplete list, the implicit submission mechanism kicks in, and the form is submitted. This change allows for selection, without killing the accessible behaviour.
|
@franzliedke I want to bump this - I've been using a fork to have it. |
|
@franzliedke I'm sorry - I just assumed this as you were a reviewer. I hope the package maintainers will take this PR into consideration :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed a couple of years ago on issue #2, whenever pressing enter to select from the autocomplete list, the implicit submission mechanism kicks in and the form is submitted.
This change allows for safe selection, without killing the accessible behaviour.