Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move console messages to their own module #343

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: move console messages to their own module #343

wants to merge 2 commits into from

Conversation

jaebradley
Copy link

@jaebradley jaebradley commented Aug 20, 2020

Summary

The console.error messages are effectively constants that make reading the logic in index.js slightly more tedious.

By moving these message strings to their own module, this slightly cleans up the logic in index.js.

Also, this adds some tests for whether these console.errors were called with the appropriate text.

Definitely understandable if this isn't merged as this type of code organization can be more a matter of taste than anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant