Extended diff option to allow for a custom differ function #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 83.56% 83.78% +0.22%
==========================================
Files 5 5
Lines 146 148 +2
==========================================
+ Hits 122 124 +2
Misses 24 24
Continue to review full report at Codecov.
|
thiamsantos
reviewed
Jun 9, 2017
src/diff.js
Outdated
| export default function diffLogger(prevState, newState, logger, isCollapsed) { | ||
| const diff = differ(prevState, newState); | ||
| export default function diffLogger(prevState, newState, logger, isCollapsed, customDiffer) { | ||
| const diff = (customDiffer || differ)(prevState, newState); |
There was a problem hiding this comment.
Maybe you could use default paremeters.
There was a problem hiding this comment.
@thiamsantos Yeah that makes sense -> b1f3281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Immutable.js alongside an Immutable.js Object Formatter Chrome Extension, and it would be great to be able to use a custom differ instead of needing to convert everything via the
stateTransformeroption.