Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(collections): use library language in tmdb query #395

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.48%. Comparing base (f1a3948) to head (f290ff4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   71.52%   71.48%   -0.04%     
==========================================
  Files          12       12              
  Lines        1085     1087       +2     
==========================================
+ Hits          776      777       +1     
- Misses        309      310       +1     
Flag Coverage Δ
Linux 71.48% <50.00%> (-0.04%) ⬇️
Windows 71.48% <50.00%> (-0.04%) ⬇️
macOS 71.48% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/tmdb_helper.py 82.97% <100.00%> (+0.37%) ⬆️
Contents/Code/plex_api_helper.py 53.33% <0.00%> (-0.17%) ⬇️

@ReenigneArcher ReenigneArcher force-pushed the fix(collections)-use-library-language-in-tmdb-query branch from d591e7b to 6da16b9 Compare March 17, 2024 15:18
@ReenigneArcher ReenigneArcher force-pushed the fix(collections)-use-library-language-in-tmdb-query branch from 6da16b9 to f290ff4 Compare March 17, 2024 19:04
@ReenigneArcher
Copy link
Member Author

@x1ao4 Could you give this PR another test?

@x1ao4
Copy link

x1ao4 commented Mar 18, 2024

It worked, I got the collection theme songs with Chinese titles, well done!

@ReenigneArcher
Copy link
Member Author

@x1ao4 Great, thank you for testing! Next issue is getting the settings page localized.

@ReenigneArcher ReenigneArcher marked this pull request as ready for review March 18, 2024 14:34
@ReenigneArcher ReenigneArcher merged commit 19573c1 into master Mar 18, 2024
20 of 21 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(collections)-use-library-language-in-tmdb-query branch March 18, 2024 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chinese collections cannot fetch theme songs.
2 participants