Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

feat: add support for collections #140

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Aug 9, 2023

Description

This PR adds support for adding themes to collection items in Plex. Since collections cannot have metadata agents, it does so by looping over every library with a scheduled task. The interval for the scheduled task is configurable.

Additionally, since we are looping over every library, this PR also adds the option to update themes for movies during the same update loop.

Themerr-plex now will also only update themes if required, i.e. the theme song that was previously used does not match the theme song listed in ThemerrDB.

Todo:

  • Simplify and commonize logic for adding themes, since there are now 3 different methods for triggering a theme to be added (metadata agent, websocket listener, and scheduled task).
  • Ensure docstrings are updated for new and existing methods.
  • Use queue for scheduled update loop.
    • Ensure library has Themerr-plex enabled for legacy agents (see below)
  • Update web report to include collections.
  • Add ability to update collection poster, art, summary
  • Update issue urls in web report to use new ThemerrDB template
    • Use LizardByte db to get info about games/collections/franchises for issue urls
    • Use TMDB api to get movie collection IDs for issue urls
  • Ensure new python files are added to code docs
  • Fix web server shutdown function (unable to resolve...)
  • Log Themerr-plex version to logs
  • Add a pre-build mechanism to speed up report generation (separate PR)

Check if Themerr-plex is enabled:

  • /system/agents/com.plexapp.agents.themoviedb/config/1
  • /system/agents/com.plexapp.agents.imdb/config/1
  • /system/agents/dev.lizardbyte.retroarcher-plex/config/1

1 indicates Movie library, 2 indicates TV library... of course need to include access token.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the feat-add-support-for-collections branch 14 times, most recently from a4e63a1 to 2a09f94 Compare August 13, 2023 20:08
@ReenigneArcher ReenigneArcher force-pushed the feat-add-support-for-collections branch 9 times, most recently from 8bd5abb to ffc5396 Compare August 19, 2023 15:56
@ReenigneArcher ReenigneArcher marked this pull request as ready for review August 19, 2023 15:59
@ReenigneArcher ReenigneArcher force-pushed the feat-add-support-for-collections branch from ffc5396 to 1558f2e Compare August 21, 2023 15:48
@ReenigneArcher ReenigneArcher force-pushed the feat-add-support-for-collections branch from 1558f2e to 3028002 Compare August 25, 2023 19:02
@ReenigneArcher ReenigneArcher merged commit aaa5e12 into nightly Aug 25, 2023
21 checks passed
@ReenigneArcher ReenigneArcher deleted the feat-add-support-for-collections branch August 25, 2023 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant