Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): Touch input broken #3240

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

BayLee4
Copy link
Contributor

@BayLee4 BayLee4 commented Sep 29, 2024

Description

Pull request #2550 fixed the macOS mouse input mode but broke the touchscreen mode in the process : tapping anywhere on the screen doesn't work anymore. Looking at the changes it seems the CGWarpMouseCursorPosition(location) was removed in post_mouse(), restoring it fixes the touchscreen issue. From my testing mouse input mode is unaffected by this change, but I do not have access to Minecraft Java Edition or Tomb Raider as described in #2550.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 29, 2024 14:28
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.85%. Comparing base (ec506bb) to head (e7867a0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3240      +/-   ##
=========================================
+ Coverage    9.65%   9.85%   +0.19%     
=========================================
  Files         101     101              
  Lines       17973   17975       +2     
  Branches     8401    8402       +1     
=========================================
+ Hits         1735    1771      +36     
+ Misses      13352   13330      -22     
+ Partials     2886    2874      -12     
Flag Coverage Δ
Linux 7.27% <ø> (ø)
Windows 5.07% <ø> (ø)
macOS-12 10.82% <100.00%> (+0.03%) ⬆️
macOS-13 10.71% <100.00%> (-0.01%) ⬇️
macOS-14 10.02% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/macos/input.cpp 39.10% <100.00%> (+0.34%) ⬆️

... and 31 files with indirect coverage changes

Copy link

sonarcloud bot commented Sep 29, 2024

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 29, 2024 15:22
@ReenigneArcher ReenigneArcher merged commit 5bc32cd into LizardByte:master Sep 29, 2024
38 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants