-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(macos): properly handle accessibility permission #2508
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2508 +/- ##
=========================================
+ Coverage 9.12% 9.13% +0.01%
=========================================
Files 97 97
Lines 17433 17451 +18
Branches 8314 8321 +7
=========================================
+ Hits 1590 1594 +4
- Misses 13021 15056 +2035
+ Partials 2822 801 -2021
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Needs test coverage on the new methods |
If we are going to test this, this has to be tested only on CI, this cannot be tested on macports test action. |
2340497
to
062d1fb
Compare
Waiting for #2550 to create the tests |
062d1fb
to
c24e808
Compare
This needs to be updated and tested on macOS Sequoia before merging. |
Description
Check for macOS Accessibility permission to allow mouse and keyboard input events to work properly.
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.