Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Refactoring #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Some Refactoring #6

wants to merge 5 commits into from

Conversation

gronke
Copy link

@gronke gronke commented Dec 18, 2017

  • minor optimizations
  • be explicit with comparisons

@LionC
Copy link
Owner

LionC commented Jan 17, 2018

Hi gronke,

thanks for your PR! I am currently thinking about porting the project to ES6 or even TypeScript altogether, so I hope you understand that I will have to leave your PR unmerged until there is a decision on that, as it improves a lot of ES5 code. So give me some more time - I will definetly incorporate the PR one way or the other!

Regards
Leon

@gronke
Copy link
Author

gronke commented Mar 23, 2018

@LionC sure thing! Let me know when it's time for a rebase.

@NKjoep NKjoep mentioned this pull request Oct 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gronke @LionC