Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Proxy-Authorization support #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shazron
Copy link

@shazron shazron commented Aug 30, 2021

When using express as a proxy server using node-http-proxy, and express-basic-auth as middleware, this middleware needs to get the authorization from the Proxy-Authentication header instead.

This is described in the example in your basic-auth dependency: https://github.com/jshttp/basic-auth#example

@LionC
Copy link
Owner

LionC commented Nov 24, 2021

Thanks for the PR! This looks like it should be supported, I am just not too sure about the exact options format yet. We should probably make the steps clearer if we have that conditional by first reading from a header which is switched based on some option and then always using parse. as that is what auth(req) does under the hood anyways, but it is not immediately clear when reading that ternary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants