fixed epoch_interruption on new wasm instance creation #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rennergade
reviewed
Jan 20, 2025
| @@ -316,6 +316,7 @@ impl<T: Clone + Send + 'static + std::marker::Sync, U: Clone + Send + 'static + | |||
|
|
|||
| let lind_manager = child_ctx.lind_manager.clone(); | |||
| let mut store = Store::new_with_inner(&engine, child_host, store_inner); | |||
| store.set_epoch_deadline(1); | |||
There was a problem hiding this comment.
add a one line comment here about what this is doing
There was a problem hiding this comment.
these comments don't really explain why we would do this or what this is
rennergade
reviewed
Jan 20, 2025
| @@ -556,6 +557,7 @@ impl<T: Clone + Send + 'static + std::marker::Sync, U: Clone + Send + 'static + | |||
| let instance_pre = Arc::new(child_ctx.linker.instantiate_pre(&child_ctx.module).unwrap()); | |||
|
|
|||
| let mut store = Store::new_with_inner(&engine, child_host, store_inner); | |||
| store.set_epoch_deadline(1); | |||
rennergade
reviewed
Jan 20, 2025
| @@ -634,6 +634,10 @@ impl Engine { | |||
| self.inner.epoch.fetch_add(1, Ordering::Relaxed); | |||
| } | |||
|
|
|||
| pub fn decrement_epoch(&self) { | |||
rennergade
reviewed
Jan 20, 2025
| @@ -424,6 +424,8 @@ impl RunCommand { | |||
| thread::sleep(timeout); | |||
| engine.increment_epoch(); | |||
| }); | |||
| } else if self.run.common.wasm.epoch_interruption.is_some() { | |||
rennergade
requested changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very minor PR. Fixed this issue by initializing epoch when new wasm instance is created.
This is the initial integration of epoch_interruption into lind's architecture. We plan to use epoch_interruption to implement several features (thread cancelation feature and signal implementation), so having a basic epoch_interruption working here is a good start.
Epoch is an u64 variable and we can use it as an integer if we want. But currently we only need to use epoch has a way to interrupt the wasm process, it is sufficient to just use 0 and 1 on epoch to represent
normalandinterruptedrespectively. So I am setting epoch deadline to be always 1 here.