Possible Refactoring Targets

This is an ongoing list of possible things to refactor, and otherwise change, on a code level. Some parts will have issues opened, but others may not until the changes have been discussed and vetted.

General

Run various linters over Light Table and, as needed, make appropriate changes.

dom.cljs

• See https://github.com/LightTable/LightTable/issues/2273
• Move event related functions ->ev, trigger on, on*, off, prevent, stop-propagation, ready from dom.cljs into events.cljs as they are DOM event related functions.
• Move style related functions top, bottom, left, right from dom.cljs into style.cljs as they are style related. Also consider which of the two namespaces is better for height, width, scroll-width, offset-top, scroll-top.
• Investigate if empty should use .-innerText or .-textContent instead of .-innerHTML.
• Investigate if now should use Date.now() instead of (.getTime (js/Date.)).
• Investigate if $ and its character reference of $ should be added to entities.

ipc.cljs

• Make ipc def private (?)

load.cljs

• Make fpath, fs defs private (?)
• Remove separator and absolute? functions in favor of files.cljs's implementations.

editor.cljs and files.cljs

• More meaningful parameter names. See https://github.com/LightTable/LightTable/issues/2263

docs.cljs

• More meaningful name for namespace... docs could mean multiple things, especially since we have an integrated doc plugin.

doc.cljs (Integrated Document Plugin)

• Split inline doc and sidebar language doc into separate namespaces or otherwise provide clear delineation between the two.