Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licensing data for https://reuse.software/ #1316

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

FedericoCeratto
Copy link
Contributor

This could be used to later remove img/README.md and simplify license management using reuse lint in CI
Please review the licensing data before merging.
The project can then be registered at https://api.reuse.software/register to obtain a badge similar to https://api.reuse.software/info/codeberg.org/FedericoCeratto/rrdnsd

@ubruhin
Copy link
Member

ubruhin commented Feb 28, 2024

Thanks for working on this @FedericoCeratto! 🎉

I didn't review the dep5 file yet in detail, but I totally agree it makes sense to replace the img/README.md by a structured format.

What bothers my a little bit is to add all the license files which are kind of unnecessary duplication since they are easily available in the internet (they could probably even be automatically downloaded on demand by a tool) 🙈 Luckily there are not too many files, but still generally I like to keep the repository as clean as possible. But I know it's not your decision as it is specified by REUSE. Maybe @dbrgn has any opinion about that?

In any way, I'll try to review the dep5 soon. I also opened LibrePCB/docker-librepcb-dev#34 to keep in mind adding reuse lint to our CI Docker images.

@ubruhin ubruhin added this to the 1.1.0 milestone Mar 11, 2024
@ubruhin ubruhin force-pushed the reuse branch 2 times, most recently from a4ba3d6 to 134c345 Compare March 20, 2024 13:53
@ubruhin
Copy link
Member

ubruhin commented Mar 21, 2024

I have now removed the Files: * entry because it would wrongly apply a license to any file we forgot to list. And now CI fails (of course) because of some very old icons we don't know the license of:

* img/actions/add_component.png
* img/actions/export_gerber.png
* img/actions/export_zip.png
* img/actions/new_folder.png
* img/actions/select.png
* img/library/3d_model.png
* img/library/component.png
* img/library/device.png
* img/places/file.png
* img/places/folder.png
* img/places/folder_open.png
* img/status/info.png

So I think we have to replace these icons first before we can get this PR merged.

@FedericoCeratto
Copy link
Contributor Author

@ubruhin I suggest rebasing this PR on top of #1336 - I haven't done it because you force-pushed some commits and I don't want to mess up you local git checkout

@ubruhin
Copy link
Member

ubruhin commented Mar 22, 2024

@FedericoCeratto I think it makes more sense the other way around, i.e. getting this PR ready first, then updating #1336. This is almost done as I have replaced some icons with unknown license, now only a few ones are left:

* img/actions/new_folder.png
* img/actions/select.png
* img/library/3d_model.png
* img/library/device.png
* img/places/folder.png
* img/places/folder_open.png

@ubruhin
Copy link
Member

ubruhin commented Mar 22, 2024

Found the source of these icons, now all licenses are clarified and reuse lint succeeds on CI!

If there are no objections, I'll merge this soon.

@FedericoCeratto
Copy link
Contributor Author

@ubruhin OK!

@ubruhin ubruhin merged commit 283f5ed into LibrePCB:master Mar 23, 2024
11 checks passed
@FedericoCeratto FedericoCeratto deleted the reuse branch March 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants