Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first iteration of locking enemy data / readonly mode #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

first iteration of locking enemy data / readonly mode #94

wants to merge 2 commits into from

Conversation

travisneids
Copy link

No description provided.

@travisneids
Copy link
Author

First attempt at a very dumbed down version of a read-only mode related to issue #67. Once enemy/route data is cleaned up we can hopefully add a reference to which pull an enemy belongs to in the DungeonToolsEnemyMixin:OnClick() function but as of right now there is no easy way to give DungeonEnemies objects context of which Pull it belongs to

srenauld
srenauld requested changes Jan 4, 2021
View reviewed changes
DungeonEnemies.lua Outdated Show resolved Hide resolved
DungeonTools.lua Outdated Show resolved Hide resolved
@travisneids
Copy link
Author

travisneids commented Jan 5, 2021 •
edited

@srenauld thank you for the suggestions. I removed the setting from the addon DB and I also refactored some of the code to make it more scalable (ReadOnlyMode) as I'm sure there will be more than just locking the enemy's placements in future releases for Read Only mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srenauld srenauld srenauld requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisneids @srenauld