Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gavilya version v.4.3.0.2312 #437

Merged
merged 13 commits into from
Dec 9, 2023
Merged

Gavilya version v.4.3.0.2312 #437

merged 13 commits into from
Dec 9, 2023

Conversation

Bamboooz
Copy link
Contributor

@Bamboooz Bamboooz commented Dec 5, 2023

Gavilya version v.4.2.0.2312:

CHANGELOG:

  • Added Gavilya icon in the top left side of the app
  • Adjusted settings button margin which was slightly off
  • When hovering on games the text was "Play to {game_name}" instead of "Play {game_name}"
  • Changed the blue gradient in the displayed images when nothing is in the library/favorites page to a purple gradient to fit the applications style
  • Changed the play button gradient from blue to purple, and in the home page display the play button only when hovering on game card, instead of it always being there
  • Slight margin changes in the game card view
  • Steam games are now launched using steam://rungameid/{game_id} which launches the steam with it if it is not already opened,
    which means you don't have to have to open steam yourself.
  • Created a separate favorites page, instead of favorited games being in the navbar. Favorite games tab has been removed from the library list view and you can see the favorited games normally in
    the games tab, they just have a star icon on them.
  • Fixed many code style inconsistencies, like double free lines somewhere, in one files no space between the license info and in others there was one etc.
  • Added a python script to add license info to all C# files if it is not already in them
  • "What game do you wanna play" text in the home page replaced with "What game do you want to play"
  • Added a "this week" tab to the recent page

obraz_2023-12-05_163446827

image

image

image

image

add gavilya icon
move favorites to a separate page
blue gradients -> purple gradients
fix typos
style code
@Bamboooz Bamboooz changed the title push v.4.2.0.2312: Gavilya version v.4.2.0.2312: Dec 5, 2023
@Bamboooz Bamboooz changed the title Gavilya version v.4.2.0.2312: Gavilya version v.4.2.0.2312 Dec 5, 2023
@lpeyr
Copy link
Member

lpeyr commented Dec 8, 2023

I will review this and check if everything is good and I'll merge. Thank you very much and sorry for late response.

@Bamboooz
Copy link
Contributor Author

Bamboooz commented Dec 8, 2023

No problem, very fun project to work on, there is just one bug left to fix - I've been working on it for a few days, but I can't find the cause. When in the settings you select favorites page as the main page, the navbar button highlight on the favorites page button does not appear, but it does when you open that page on your own.

@Bamboooz
Copy link
Contributor Author

Bamboooz commented Dec 8, 2023

And maybe other small things like some README changes, like the version text change in it, as I put this pull request as as a whole update as there is quite a lot of changes there. When I will be home today I will check for any inconsistencies and address them in an additional commit.

@lpeyr lpeyr self-requested a review December 8, 2023 10:10
Copy link
Member

@lpeyr lpeyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix some slight mistakes in french translations.

Gavilya/Components/NavBarComponent.xaml Outdated Show resolved Hide resolved
Gavilya/Properties/Resources.fr-FR.resx Outdated Show resolved Hide resolved
Gavilya/Properties/Resources.fr-FR.resx Outdated Show resolved Hide resolved
Gavilya/Properties/Resources.fr-FR.resx Outdated Show resolved Hide resolved
Gavilya/Properties/Resources.fr-FR.resx Outdated Show resolved Hide resolved
@lpeyr
Copy link
Member

lpeyr commented Dec 8, 2023

I fixed all the issues I was able to find for now. If I don't find any other issues, I will merge and release tomorrow.
Thank you again for your ideas and your contribution!

@Bamboooz
Copy link
Contributor Author

Bamboooz commented Dec 8, 2023

Give me 1 more day, I am going to do some finishing touches.

@Bamboooz
Copy link
Contributor Author

Bamboooz commented Dec 8, 2023

Done, ready for merging.

@lpeyr lpeyr self-requested a review December 9, 2023 10:51
@lpeyr lpeyr changed the title Gavilya version v.4.2.0.2312 Gavilya version v.4.3.0.2312 Dec 9, 2023
@lpeyr lpeyr self-assigned this Dec 9, 2023
@lpeyr lpeyr added enhancement New feature or request vNext Issues planned for the next version labels Dec 9, 2023
@lpeyr lpeyr merged commit e2251cc into Leo-Corporation:main Dec 9, 2023
1 check passed
@lpeyr
Copy link
Member

lpeyr commented Dec 9, 2023

Thank you again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vNext Issues planned for the next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants