This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
forked from jsbin/jsbin
-
Notifications
You must be signed in to change notification settings - Fork 7
Rebase on JS Bin v3.41.10 #6
Open
ghybs
wants to merge
405
commits into
Leaflet:master
Choose a base branch
from
ghybs:3.41.10
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hate this repetitive code so much :(
Ref jsbin#2719 Looks like the secureOutput logic is getting confused when landing on a vanity page as it's reading the user's SSL settings then redirecting, instead of reading the vanity owner (which we'll handle else IIRC).
update from three 72 -> 82
Plus trying out fullstory
(cherry picked from commit 3144173)
(cherry picked from commit 0e61f17)
(cherry picked from commit 4ad5407)
(cherry picked from commit 9bb92f4)
(cherry picked from commit 2d8750f)
(cherry picked from commit e572274)
HTTPS does not work on Leaflet CDN (cherry picked from commit 7c76c53)
(cherry picked from commit e3d492b)
(cherry picked from commit 8165e6b)
(cherry picked from commit cc5de2c)
(cherry picked from commit 4920e7e)
(cherry picked from commit 1108f8f)
(cherry picked from commit d3ee0a9)
(cherry picked from commit 7be84d0)
(cherry picked from commit e4aecad)
(cherry picked from commit f702815)
so that it is easier to make up live test cases and it avoids confusion about maintained / available versions. (cherry picked from commit 014ec4d)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #5, this is an attempt to rebase Leaflet customizations on top of JS Bin
v3.41.10
, i.e. the latest release supporting sqlite.However I was not able to test it fully, as I did not have time to build sqlite to run it.
Use node < 0.11 (e.g.
v0.10.48
).Please let me know what comes out of it, and/or how I could help further.