This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
trigger a custom event 'StyleFixProcessed' #6134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a custom event 'StyleFixProcessed' to indicate when the styles are fixed. This is needed for situations that entail further processing, such as described in #6132
Split variable handling into two parts so fallback handling could be recursive. Fixed fallback whitespace and nested variable handling. Parsing now handles more cases with parentheses. Addresses #6132 by using new custom event to get the last value of variables after they are all processed (which meant a little bit of duplicated code for the second pass).
Closed
|
What about when there are multiple stylesheets, and multiple StyleFix rules? Do you fire one or more events? If one, does it fire correctly at the end? Also, it seems you accidentally included some other changes in this PR? |
|
The event is for when all of the |
|
Merged, thanks. |
|
Yes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom event 'StyleFixProcessed' to indicate when the styles are fixed.
This is needed for situations that entail further processing, such as described in #6132