Add redirect option to delete button script #5723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
When an entry was deleted from
showoperation, the deleted entry was kept on screen and just an alert was shown.As you can see, that is a deleted entry that still had the
actions(delete, edit, etc) available to be clicked, but none of them work since the entry was already deleted.AFTER - What is happening after this PR?
The delete button can now accept an url to redirect after an entry is deleted.
HOW
How did you achieve that, in technical terms?
Added a
deleteButtonRedirectoperation setting and setup some sane defaults: - if user has access to ListOperation, redirect to list, else, redirect to previous page.This can all be configured by developer if the defaults are not enough for them.
ListOperation still ignores this setting since a table is present on the page, and in that case we keep the previous behavior of re-drawing the table, no redirects.
Is it a breaking change?
Is can be seen as one. No app is going to break, but the behavior changed. I wouldn't consider it a breaking change, but @tabacitu thinks it's better to treat it as one, in that case I am marking this for v7