allow datatable url configuration #5713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabacitu
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Datatables url was hardcoded to
CRUD::getRoute(), by that reason it was not possible to use datatables in any other place than the main crud route, eg:$this->crud->setRoute('monsters'), would only allow a datatable in that specific url, trying to add a datatable inmonsters/some-pagewould break things like filters, and require "hacking solutions" to try to overcome the search functionality.AFTER - What is happening after this PR?
The datatable can be setup in any additional page by configuring the
datatablesUrl, for that reason it's now possible to have filters and search without convoluted solutions.HOW
How did you achieve that, in technical terms?
Replaced all
$crud->getRoute()calls in datatables and filter scripts by$crud->getOperationSetting('datatablesUrl')and setup a defaultdatatablesUrl($crud->getRoute())` to keep it backward compatible.Is it a breaking change?
No