[WIP] add missing attribute on checkbox fields #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox and Checkbox fields don't use the BS class
form-check-input.Adding the class for Tabler was a non-issue because adding the form-check-input does not break anything and we are able to target the checkboxes without targeting "specific fields" (like the checkbox in a checklist or whatever).
But it breaks for CoreUI's, because the themes provide the attribute styled, but we never used it, and now we would need to release a new CRUD and lock the themes (coreui v2 and v4) to v6.6.x. that I think at this time (very close to a new major), we better do it there I think.