-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string completion to field and column type parameter #5341
base: main
Are you sure you want to change the base?
Conversation
There is an alternative to this that enables the user to go to the column/field blade file with
|
I LOVE IT! Yes @susanu , I totally agree to adding this. I've just started using PHPStorm + Laravel Idea too, and I would LOVE IT if it were able to help me like this, yes. Feel free to polish this PR until you're reasonably happy with it. Then I'll take a look, test and and merge. Don't go overboard 😀 I think it's better to cover the most useful things, merge it... and then we can add more later if needed. Thank you! |
Hi @tabacitu, Currently i'm waiting for a response from the plugin creator to implement 2 things:
After i get a response, i will update this pull request with the necessary changes. |
Hey @susanu , I see the two issues in the laravel-idea plugin have been closed. Any idea how to change this to benefit from the new features? Cheers! |
Hi @tabacitu, I will update the pull request this week. Thank you! |
Hi @tabacitu, I updated the file, it has the following completions:
Let me know if that works for you. |
WHY
Make life easier for developers who use Laravel idea plugin for phpstorm.
BEFORE - What was wrong? What was happening before this PR?
No autocompletion for type parameter for columns and fields.
AFTER - What is happening after this PR?
A list of possible values for type parameter for fields and columns
HOW
How did you achieve that, in technical terms?
Adding the
ide.json
file in the root package for Laravel idea to pick it upIs it a breaking change?
No
How can we test the before & after?
Have Laravel idea installed into Phpstorm.
Type
date
into thetype
function for a column or a field with and without theide.json
file.CRUD::column('column')->type('date')
CRUD::field('column')->type('date')
If this pull will get merged, i will come back with the rest of things that can be completed.
More info: https://laravel-idea.com/docs/ide_json/completion