bugfix, static check

LakshSingla · Sep 7, 2023 · 357d2ff · 357d2ff
1 parent ef4a529
commit 357d2ff
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/processing/src/main/java/org/apache/druid/frame/field/DoubleFieldWriter.java b/processing/src/main/java/org/apache/druid/frame/field/DoubleFieldWriter.java
@@ -29,8 +29,6 @@
  */
 public class DoubleFieldWriter extends NumericFieldWriter
 {
-  public static final int SIZE = Double.BYTES + Byte.BYTES;
-
   private final BaseDoubleColumnValueSelector selector;
 
   public static DoubleFieldWriter forPrimitive(final BaseDoubleColumnValueSelector selector)

diff --git a/processing/src/main/java/org/apache/druid/frame/field/LongFieldReader.java b/processing/src/main/java/org/apache/druid/frame/field/LongFieldReader.java
@@ -60,11 +60,6 @@ public ValueType getValueType()
     return ValueType.LONG;
   }
 
-  public Class<? extends Long> getClassOfObject()
-  {
-    return Long.class;
-  }
-
   @Override
   public ColumnValueSelector<?> getColumnValueSelector(
       final Memory memory,

diff --git a/processing/src/main/java/org/apache/druid/frame/read/FrameReader.java b/processing/src/main/java/org/apache/druid/frame/read/FrameReader.java
@@ -110,7 +110,14 @@ public static FrameReader create(final RowSignature signature)
 
       fieldReaders.add(FieldReaders.create(signature.getColumnName(columnNumber), columnType));
 
-      if (columnType.getType() == ValueType.ARRAY && columnType.getType() != ValueType.STRING) {
+      // TODO(laksh): comment
+      if (columnType.getType() == ValueType.ARRAY
+          && Preconditions.checkNotNull(
+          columnType.getElementType(),
+          "Element type for array column [%s]",
+          signature.getColumnName(columnNumber)
+      ).getType() != ValueType.STRING
+      ) {
         if (!unsupportedColumnAndType.isPresent()) {
           unsupportedColumnAndType = Optional.of(Pair.of(signature.getColumnName(columnNumber), columnType));
         }