Skip to content

Commit

Permalink
remove tests that relied on numeric arrays being unsupported
Browse files Browse the repository at this point in the history
  • Loading branch information
LakshSingla committed Sep 7, 2023
1 parent a5f24c5 commit 3249066
Showing 1 changed file with 0 additions and 36 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,42 +75,6 @@ public void test_columnar()
Assert.assertEquals(ALLOCATOR_CAPACITY, factory.allocatorCapacity());
}

@Test
public void test_rowBased_unsupportedSortingColumnType()
{
final UnsupportedColumnTypeException e = Assert.assertThrows(
UnsupportedColumnTypeException.class,
() -> FrameWriters.makeFrameWriterFactory(
FrameType.ROW_BASED,
new ArenaMemoryAllocatorFactory(ALLOCATOR_CAPACITY),
RowSignature.builder().add("x", ColumnType.LONG_ARRAY).build(),
Collections.singletonList(new KeyColumn("x", KeyOrder.ASCENDING))
)
);

Assert.assertEquals("x", e.getColumnName());
Assert.assertEquals(ColumnType.LONG_ARRAY, e.getColumnType());
}

@Test
public void test_rowBased_unsupportedNonSortingColumnType()
{
final FrameWriterFactory factory = FrameWriters.makeFrameWriterFactory(
FrameType.ROW_BASED,
new ArenaMemoryAllocatorFactory(ALLOCATOR_CAPACITY),
RowSignature.builder().add("x", ColumnType.LONG_ARRAY).build(),
Collections.emptyList()
);

final UnsupportedColumnTypeException e = Assert.assertThrows(
UnsupportedColumnTypeException.class,
() -> factory.newFrameWriter(new AllNullColumnSelectorFactory())
);

Assert.assertEquals("x", e.getColumnName());
Assert.assertEquals(ColumnType.LONG_ARRAY, e.getColumnType());
}

@Test
public void test_columnar_unsupportedColumnType()
{
Expand Down

0 comments on commit 3249066

Please sign in to comment.