Adding downstream accuracy CCL params #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fjaviersanchez do we know if these are passed to Firecrown? |
|
No. Not for sure. I need confirmation from @marcpaterno and/or @vitenti . |
|
I am suspecting that since it will be in the same session of ccl it won't change those values, but can't tell if that's always the case. |
|
I think we also this into I am working on #60 to make that easier for the user. I think eventually we will shift towards only using pre-made firecrown likelihoods as this allows us make use of firecrown's |
arthurmloureiro
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #56, and adds the ability to pass along CCL accuracy parameters through
augur. I still have to check whether these are passed downstream to firecrown (I suspect so, but not 100% sure).