Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/48 - Redshift distributions from file #49

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

fjaviersanchez
Copy link
Collaborator

Trying to address #48. This PR adds the ability to read either a text file (with format z, dndz_0, dndz_1, dndz_2, ...) or an npy file (with the same format as the one that is returned by CCLX) and assign it to a tracer.

Copy link
Collaborator

@arthurmloureiro arthurmloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I tested here and it works out of the box! I'd just add a small check to see if the number of bins in the config file matches the number of bins in the file.

augur/tracers/two_point.py Show resolved Hide resolved
@arthurmloureiro arthurmloureiro added the enhancement New feature or request label Jul 4, 2024
@arthurmloureiro arthurmloureiro linked an issue Jul 4, 2024 that may be closed by this pull request
@arthurmloureiro arthurmloureiro changed the title Issues/48 Issues/48 - Redshift distributions from file Jul 4, 2024
@arthurmloureiro arthurmloureiro merged commit 7c88944 into master Jul 4, 2024
1 check passed
@arthurmloureiro arthurmloureiro deleted the issues/48 branch July 4, 2024 08:14
@fjaviersanchez
Copy link
Collaborator Author

yes, that's a good point. I should add some safeguards :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept arbitrary redshift distributions for tracers.
2 participants