Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guava dependency #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

xxDark
Copy link

@xxDark xxDark commented Jan 5, 2022

Same commit as the previous one, it removes all usages of guava from the project, since there are not so many of them.

@terminalsin terminalsin self-requested a review January 5, 2022 20:06
@terminalsin terminalsin self-assigned this Jan 5, 2022
@terminalsin terminalsin added the enhancement New feature or request label Jan 5, 2022
@terminalsin
Copy link
Member

Will have to double check this weekend to ensure this works but for the most part I'll most definitely merge this in

@rcx
Copy link
Member

rcx commented Jan 7, 2022 via email

@xxDark
Copy link
Author

xxDark commented Jan 7, 2022

If this doesn’t break anything I would love to see this merged. I don’t remember why or where we used Guava.

On Wed, Jan 5, 2022 at 15:07 Shanyu Juneja @.> wrote: Will have to double check this weekend to ensure this works but for the most part I'll most definitely merge this in — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5NBPO6QHFILSFL5CZ6EUDUUSQH7ANCNFSM5LKSNPEA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.>

I replaced guava usage with their equivalents, should not break anything. There are tests, but I'm not sure if the changes I made are tested though, but I'm pretty sure I did not miss anything.

Copy link
Member

@terminalsin terminalsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I imagined there are issues with the property-framework module failing to pass as it makes use of Guava's Eventbus. Am looking into whether we can even just remove the framework as it's unused.

@xxDark
Copy link
Author

xxDark commented Jan 8, 2022

As I imagined there are issues with the property-framework module failing to pass as it makes use of Guava's Eventbus. Am looking into whether we can even just remove the framework as it's unused.

I'll see what can be done about that. Guava does not allow to only shade the eventbus, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants