Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve get_node #229

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve get_node #229

wants to merge 1 commit into from

Conversation

michaelmckinsey1
Copy link
Collaborator

This PR makes the behavior of get_node deterministic, whether there is a single match or multiple, the default will be to return the first match

  1. Add option to return either first, last, or all matches
  2. Improve unit tests

@michaelmckinsey1 michaelmckinsey1 added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features labels Nov 13, 2024
@michaelmckinsey1 michaelmckinsey1 self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slabasan slabasan Awaiting requested review from slabasan

At least 1 approving review is required to merge this pull request.

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelmckinsey1