-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone python scripts for canned analysis #153
base: develop
Are you sure you want to change the base?
Conversation
@Thionazin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think we rename
examples.rst
tocanned_analysis.rst
and change the doc title toCanned Analysis
- Is the
examples
directory going to contain other things than python scripts? Otherwise can we remove thepython_scripts
directory level and maybe these scripts are labeled like the tutorial notebooks01A_display_valid_metadata_metric.py
,01B_stacked_line_charts.py
.
@Thionazin your unit tests are failing on flake8 formatting, make sure you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @Thionazin, this is looking pretty good to me, just a question for @pearce8 about the strong scaling graph. Also @michaelmckinsey1 can you just go over your comments and let me know if any still apply or otherwise mark them as resolved?
Once those two things are settled I'll approve it for merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pearce8 Do these strong scaling results look as expected to you? Shouldn't we be seeing speedup for higher mpi world size? Just wanted to sanity check, in case I'm just missing something. The weak scaling graph looks as I would expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the problem size was not large enough?
|
- remove examples/python_scripts/.gitignore once a python file has been added
Co-authored-by: Michael McKinsey <[email protected]>
3095a99
to
6a5a459
Compare
@Thionazin Once you have your python scripts of different analyses, please add them to this PR.