DepoSetSource

[HaiwangYu]

Adding new DepoSetSource. Passing DepoSet instead of queue of Depos. Which makes Pgrapher engine much more efficient.

[FNALbuild]

A new Pull Request was created by @HaiwangYu (Haiwang Yu) for develop.

It involves the following packages:

larwirecell

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks
for details see
https://buildmaster.fnal.gov/buildmaster/job/GithubIntegration/job/run-pr-code-checks//1099/console

[knoepfel]

@HaiwangYu, we are not planning on releasing another version of LArSoft until January. We hope you're okay with the delay.

[knoepfel]

trigger build

[FNALbuild]

The tests are being triggered in jenkins.

[FNALbuild]

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14014&builds=
+build

[FNALbuild]

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14015&builds=
+build

[FNALbuild]

-lariat failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:lariat/view_builds/index?offset=0&builds=lariat_ci/6177&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14015&builds=

[FNALbuild]

-uboone tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/6912&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14015&builds=

[FNALbuild]

+argoneut tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:argoneut/view_builds/index?offset=0&builds=argoneut_ci/6438&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14015&builds=

[FNALbuild]

-sbnd tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/8327&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14015&builds=

[FNALbuild]

-icarus tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/3382&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14015&builds=

[FNALbuild]

-dune tests warning on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/12522&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14015&builds=

[HaiwangYu]

@HaiwangYu, we are not planning on releasing another version of LArSoft until January. We hope you're okay with the delay.

Hi @knoepfel, that is totally OK. Thanks for letting me know. I checked some failed CI tests. Seems not related to this PR. Please let me know if there are some issues that I need to work on.

[knoepfel]

Looks good, @HaiwangYu. Will approve after L2 approval.

[FNALbuild]

The tests are being triggered in jenkins.

[FNALbuild]

+LArSoft tests OK on slf7 for c7:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14137&builds=
+build

[FNALbuild]

+LArSoft tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14136&builds=
+build

[FNALbuild]

-lariat failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:lariat/view_builds/index?offset=0&builds=lariat_ci/6226&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14136&builds=

[FNALbuild]

-uboone tests failed on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/6965&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14136&builds=

[FNALbuild]

+argoneut tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:argoneut/view_builds/index?offset=0&builds=argoneut_ci/6487&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14136&builds=

[FNALbuild]

+sbnd tests OK on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/8423&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14136&builds=

[FNALbuild]

-icarus tests warning, with build warning,, with ignored warning for build, on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/3465&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14136&builds=

[FNALbuild]

-dune tests warning on slf7 for e20:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/12579&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/14136&builds=

[absolution1]

It looks like raw pointers declared on the heap are used in a few places. Is there a specific motivation for that or could those be smart pointers?

[brettviren]

It looks like raw pointers declared on the heap are used in a few places. Is there a specific motivation for that or could those be smart pointers?

The m_adapter could be a unique_ptr.

This new class is a variant of an existing one so repeats an existing anti-patern. I propose that fixing these occurrences be done in some dedicated commit.

I will make an issue on this repo to remind us.

[knoepfel]

@brettviren, your suggestion sounds good. Could you reference the issue in this PR when the issue has been created? In the meantime, we will go ahead and accept the PR, assuming @absolution1 has no other concerns.

[brettviren]

It's #14

[absolution1]

Great. Thanks for doing that.
I have no other suggestions/comments.

[absolution1]

approve

[FNALbuild]

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged.)

[lgarren]

approve