Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(regressor): add regressor interface #25

Merged
merged 10 commits into from
Feb 11, 2021

Conversation

tczhao
Copy link
Contributor

@tczhao tczhao commented Feb 9, 2021

add regressor interface

resolves #14 #4

@tczhao tczhao force-pushed the feature/regressor branch from adfea6f to a58c112 Compare February 9, 2021 13:45
@tczhao tczhao force-pushed the feature/regressor branch from a58c112 to 51d498e Compare February 9, 2021 13:46
@xuyxu
Copy link
Member

xuyxu commented Feb 9, 2021

Brilliant job! Thanks @tczhao! I will take a careful look tomorrow ;-)

@tczhao
Copy link
Contributor Author

tczhao commented Feb 10, 2021

The classification performance on our highly skewed data is not that good but the regression performance is incredible

Copy link
Member

@xuyxu xuyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tczhao, I have left some comments on your PR, let me know if you are OK with them. Thanks for this great PR, I will work on the experiment parts on the regressor and let you stay stuned. Hopefully, this PR can be merged in a few days.

deepforest/cascade.py Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
deepforest/cascade.py Outdated Show resolved Hide resolved
@xuyxu
Copy link
Member

xuyxu commented Feb 10, 2021

The classification performance on our highly skewed data is not that good but the regression performance is incredible

Thanks for sharing this. Another question is that what is the final number of cascade layers in your regression dataset? If the number of 1, I am afraid that the cascade structure does not have any positive effect, and the entire model is simply an average of forest models...

EDIT: I have added the experiment on regression, you can check it via the last GitHub checks

@tczhao
Copy link
Contributor Author

tczhao commented Feb 10, 2021

The classification performance on our highly skewed data is not that good but the regression performance is incredible

Thanks for sharing this. Another question is that what is the final number of cascade layers in your regression dataset? If the number of 1, I am afraid that the cascade structure does not have any positive effect, and the entire model is simply an average of forest models...

EDIT: I have added the experiment on regression, you can check it via the last GitHub checks

Thanks for the added tests

It's 3 layer in the end (not just a simple ensemble), we set the max to 3 for some quick experiment

Copy link
Member

@xuyxu xuyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuyxu
Copy link
Member

xuyxu commented Feb 11, 2021

Thanks for your great work @tczhao! I will merge the PR soon ;-)

@xuyxu xuyxu merged commit 28a32d2 into LAMDA-NJU:master Feb 11, 2021
@xuyxu
Copy link
Member

xuyxu commented Feb 11, 2021

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Requests
2 participants