-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(regressor): add regressor interface #25
Conversation
adfea6f
to
a58c112
Compare
a58c112
to
51d498e
Compare
Brilliant job! Thanks @tczhao! I will take a careful look tomorrow ;-) |
The classification performance on our highly skewed data is not that good but the regression performance is incredible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tczhao, I have left some comments on your PR, let me know if you are OK with them. Thanks for this great PR, I will work on the experiment parts on the regressor and let you stay stuned. Hopefully, this PR can be merged in a few days.
Thanks for sharing this. Another question is that what is the final number of cascade layers in your regression dataset? If the number of 1, I am afraid that the cascade structure does not have any positive effect, and the entire model is simply an average of forest models... EDIT: I have added the experiment on regression, you can check it via the last GitHub checks |
Thanks for the added tests It's 3 layer in the end (not just a simple ensemble), we set the max to 3 for some quick experiment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your great work @tczhao! I will merge the PR soon ;-) |
Merged. |
add regressor interface
resolves #14 #4