Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This cookbook does not work with Amazon Linux. This PR fixes all known Amazon Linux specific issues. #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brenttheisen
Copy link

No description provided.

@L2G
Copy link
Owner

L2G commented Apr 25, 2015

Excellent, thanks, I will want to take a look at this. Admittedly the
RedHat/Amazon/etc. support has gotten hairy.

On Thu, Apr 23, 2015 at 11:55 PM, Brent Theisen [email protected]
wrote:


You can view, comment on, or merge this pull request online at:

#30
Commit Summary

  • Refactor RHEL pre 7 logic to another recipe.
  • Do not do RHEL 7 for Amazon Linux.

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#30.

Larry Gilbert
Computer geekery since 1976

@brenttheisen
Copy link
Author

No problem. I did this while on a pretty demanding deadline so let me know if you want changes to it.

@et304383
Copy link

et304383 commented Jul 2, 2015

I'm not sure how this resolves the issue with Amazon Linux. Amazon Linux uses /etc/localtime to determine time.

http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/set-time.html

The logic in the recipe linux-generic is actually what is used to set time on Amazon Linux.

The rhel script should simply call the generic script for Amazon.

@et304383
Copy link

et304383 commented Aug 6, 2015

I see now how this works as default calls amazon calls generic + rhel

Please merge this PR as the current recipe does NOT work on Amazon and this should fix it.

@et304383
Copy link

Is this project still alive? This PR needs to be merged. I'm still using a forked version which has just this PR merged and there have been zero changes to the repository since.

@et304383
Copy link

Can we please merge this PR so we can stop using a forked version of this repository?

@et304383
Copy link

et304383 commented Aug 9, 2016

Can we please merge this? @L2G

@et304383
Copy link

@L2G is this cookbook still supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants