fix(swagger-ui-web-component): ensure there are 4 grid columns for each operation #1422
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to verify this has the expected result, but wanted to throw up this PR since I noticed the issue |
…ch operation
Currently there is some CSS that has 3 columns, but a recently upgraded version of Swagger UI regrouped the elements so that it is now necessary to have 4 columns to prevent the open/collapse toggle button from flowing into the next row.
The current CSS rule that is offending is:
```css
.swagger-ui .opblock .opblock-summary {
grid-template-columns: 80px auto 30px;
}
Mierenga
force-pushed
the
Mierenga-patch-1
branch
from
af70dbc to
69ab9f0
Compare
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently there is some CSS that has 3 columns, but a recently upgraded version of Swagger UI regrouped the elements so that it is now necessary to have 4 columns to prevent the open/collapse toggle button from flowing into the next row.
The current CSS rule that is offending is:
before:
after:
Resources