-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify tools installation and management with mise #6564
Conversation
11c772d
to
5c6a1ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #6564 +/- ##
=======================================
+ Coverage 69.5% 73.7% +4.2%
=======================================
Files 202 202
Lines 25796 25796
=======================================
+ Hits 17935 19024 +1089
+ Misses 6853 5750 -1103
- Partials 1008 1022 +14 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the experimental setting to the .mise.toml
config file so we don't have to set it manually:
[settings]
experimental = true
0f29a23
to
879190b
Compare
Pull request was converted to draft
07537b1
to
058630f
Compare
0628226
to
acf6726
Compare
I implemented your suggestion @czeslavo and made couple of other improvements, so please check everything again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, worked on my machine π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
acf6726
to
b5a045c
Compare
b5a045c
to
056aae6
Compare
What this PR does / why we need it:
Scope
third_party
and dedicatedgo.mod
for managing tooling and all relatedMakefile
config. Usemise
to install delve from the source code (a binary is not provided).gotestsum
is handled nativelycrd-ref-docs
use the same approach for installation as fordelve
- built from sourcesetup-envtest
is handled nativelystaticcheck
is handled nativelylooppointer
linter.Which issue this PR fixes:
Follow up for #6563