Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add job to run e2e and integration tests daily for validating kong images #5317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Dec 11, 2023

What this PR does / why we need it:

Adds a daily workflow to run e2e tests and integration tests on KIC 2.12 LTS against Kong 2.8 LTS and Kong 3.4 LTS to verify compatibility.

Which issue this PR fixes:

fixes #5286

Special notes for your reviewer:

  • We need to enable this after KIC 2.12.3 releases Release v2.12.3 #5257 to include the fixes.
  • Do we need to run against on kubernetes versions and GKE clusters?

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner December 11, 2023 08:15
@randmonkey randmonkey force-pushed the ci/run_validate_kong_image_daily branch from b970087 to ab4d2f3 Compare December 11, 2023 08:17
@randmonkey randmonkey marked this pull request as draft December 11, 2023 08:17
@randmonkey randmonkey changed the title add job to run e2e and integration tests daily for validating kong im… test: add job to run e2e and integration tests daily for validating kong images Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4f82f6) 75.9% compared to head (ab4d2f3) 75.8%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5317     +/-   ##
=======================================
- Coverage   75.9%   75.8%   -0.1%     
=======================================
  Files        170     170             
  Lines      19447   19447             
=======================================
- Hits       14767   14757     -10     
- Misses      3851    3858      +7     
- Partials     829     832      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey marked this pull request as ready for review December 26, 2023 03:31
@pmalek
Copy link
Member

pmalek commented Apr 16, 2024

Do we need to run against on kubernetes versions and GKE clusters?

I believe at least for starters we can "just" run this as usual on kind. We can add e.g. running on GKE when the pipeline proves to be stable.


@randmonkey Is this still blocked on something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run validate Kong image test regularly
2 participants