Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): hermetic install of files after build #12882

Merged
merged 3 commits into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ common --color=yes
common --curses=auto

build --experimental_ui_max_stdouterr_bytes=10485760
# required to build shared library on macOS
# TODO: remove after bump to bazel >= 7
build --experimental_cc_shared_library

build --show_progress_rate_limit=0
Expand Down
37 changes: 26 additions & 11 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,18 @@ config_setting(
visibility = ["//visibility:public"],
)

config_setting(
name = "debug_linux_flag",
constraint_values = [
"@platforms//os:linux",
],
flag_values = {
":debug": "true",
},
visibility = ["//visibility:public"],
)

# --//:brotli=true
bool_flag(
name = "brotli",
build_setting_default = True,
Expand All @@ -136,17 +148,6 @@ config_setting(
visibility = ["//visibility:public"],
)

config_setting(
name = "debug_linux_flag",
constraint_values = [
"@platforms//os:linux",
],
flag_values = {
":debug": "true",
},
visibility = ["//visibility:public"],
)

# --//:licensing=false
bool_flag(
name = "licensing",
Expand Down Expand Up @@ -258,6 +259,20 @@ config_setting(
visibility = ["//visibility:public"],
)

# --//:skip_tools=false
bool_flag(
name = "skip_tools",
build_setting_default = False,
)

config_setting(
name = "skip_tools_flag",
flag_values = {
":skip_tools": "true",
},
visibility = ["//visibility:public"],
)

##### constraints, platforms and config_settings for cross-compile

constraint_setting(name = "cross_build_setting")
Expand Down