feat(tabs): keep connection for tabs-[INS-4778] #8266
Draft
+454
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurryYangxx
force-pushed
the
feat/keep-websocket-connection
branch
from
00aee7b to
404d75e
Compare
CurryYangxx
changed the title
CurryYangxx
commented
Dec 26, 2024
Comment on lines
-455
to
-461
| // Close all websocket connections when the active environment changes | ||
| useEffect(() => { | ||
| return () => { | ||
| window.main.webSocket.closeAll(); | ||
| window.main.grpc.closeAll(); | ||
| }; | ||
| }, [activeEnvironment?._id]); |
There was a problem hiding this comment.
This a trade-off; Previously, we closed all connections when the active environment changed to avoid users not knowing which URL is currently used to connect if included some env.
Now, based on multiple tabs, we may have multiple WebSocket or grpc tabs from different workspaces, and we want to keep all the connections when the corresponding tab exists. When a workspace's active environment changes, finding which requests are affected and closing them will introduce more complexity.
So I just delete it and only close connection when tab close.
CurryYangxx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: