fix: runner select all #8256
Draft
fix: runner select all #8256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurryYangxx
commented
Dec 18, 2024
| @@ -476,10 +476,10 @@ export const Runner: FC<{}> = () => { | |||
| ? Array.from(reqList.items) | |||
| .filter(item => item.ancestorIds.includes(targetFolderId)) | |||
There was a problem hiding this comment.
is this filter necessary?
There was a problem hiding this comment.
It looks like we can drop it.
ihexxa
approved these changes
Dec 18, 2024
| @@ -476,10 +476,10 @@ export const Runner: FC<{}> = () => { | |||
| ? Array.from(reqList.items) | |||
| .filter(item => item.ancestorIds.includes(targetFolderId)) | |||
There was a problem hiding this comment.
It looks like we can drop it.
|
will merge after 10.3 |
CurryYangxx
force-pushed
the
fix/runner-select-all
branch
from
245193e to
e271c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a keyboard shortcut
⌘ Cmd + Acan select all grid list items and letselectedKeysto beall, we need to handle this case