runner improvements (multiple tabs)-[INS-4779] #8244
Conversation
| @@ -160,6 +128,8 @@ export const Runner: FC<{}> = () => { | |||
| const [bail, setBail] = useState<boolean>(true); | |||
| const [isRunning, setIsRunning] = useState(false); | |||
|
|
|||
| const runnerId = targetFolderId ? `${workspaceId}-${targetFolderId}` : workspaceId; | |||
There was a problem hiding this comment.
collection runner: workspaceId
folder runner: runnerId
If move the folder, the result will not be found
CurryYangxx
changed the title
|
|
||
| useInterval(() => { | ||
| refreshPanes(); | ||
| }, isRunning ? 1000 : null); |
There was a problem hiding this comment.
only start interval when runner is running
| } catch (e) { | ||
| // the error could be from third party | ||
| const errMsg = encodeURIComponent(e.error || e); | ||
| return redirect(`/organization/${organizationId}/project/${projectId}/workspace/${workspaceId}/debug/runner?refresh-pane&error=${errMsg}&folder=${targetFolderId}`); |
There was a problem hiding this comment.
do not return redirect, because we can not receive the redirect response if we navigate to another route
CurryYangxx
force-pushed
the
feat/multiple-tab
branch
from
1d3516e to
f4cbf3c
Compare
CurryYangxx
force-pushed
the
fix/tab-runner-execution
branch
3 times, most recently
from
aa45892 to
5ed1066
Compare
CurryYangxx
force-pushed
the
feat/multiple-tab
branch
from
f4cbf3c to
6f44e5c
Compare
CurryYangxx
force-pushed
the
fix/tab-runner-execution
branch
from
7b37221 to
15dd057
Compare
| return; | ||
| } | ||
|
|
||
| const index = currentTabs.tabList.findIndex(tab => deleteIds.includes(tab.id)); |
There was a problem hiding this comment.
It seems to be !deleteIds.includes(tab.id) here.
There was a problem hiding this comment.
I want to find the first deleted element and then navigate to the adjacent tab to the left of it
| }, []); | ||
|
|
||
| const handleTabClose = useCallback((ids: 'all' | string[]) => { | ||
| if (ids === 'all') { |
There was a problem hiding this comment.
Will it clean all runner tab states under all orgs?
There was a problem hiding this comment.
Already changed the data structure 9c2f31c, will only clean up the runner states in current org
runnerState: {
orgId: {
runnerId: {}
}
}
533da88 to
9c2f31c
Compare
| @@ -0,0 +1,37 @@ | |||
| type EventHandler = (...args: any[]) => void; | |||
There was a problem hiding this comment.
nit: lets name these files with hyphen event-bus and tabList here or in the main feature branch.
There was a problem hiding this comment.
let me change the name in the main feature branch
Changes
runCollectionActionrunnerExecutionsEventBusclass