-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added new method to fetch a consumer-group without consumers. #494
base: main
Are you sure you want to change the base?
Conversation
Reverted the existing `Get` method to keep listing consumers and added a new one that uses the query parameter `list_consumers=false` to skip listing consumers for performance reasons. This is done so as to fix dump errors coming in deck when using gw 3.9+ where consumer-groups do not show the associated consumers. We will push the performant option behind a flag. For: Kong/deck#1483
ddd9227
to
a067cec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
- Coverage 55.16% 55.01% -0.15%
==========================================
Files 72 72
Lines 5754 5769 +15
==========================================
Hits 3174 3174
- Misses 1954 1969 +15
Partials 626 626
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@pmalek Could you please help with this PR review? |
Reverted the existing
Get
method to keep listing consumers and added a new one that uses the queryparameter
list_consumers=false
to skip listingconsumers for performance reasons.
This is done so as to fix dump errors coming in
deck when using gw 3.9+ where consumer-groups
do not show the associated consumers. We will
push the performant option behind a flag.
For: Kong/deck#1483