Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove unneeded version constraint in Test_FillPluginsDefaults_Acme #342

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jun 7, 2023

No description provided.

@pmalek pmalek added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests labels Jun 7, 2023
@pmalek pmalek requested a review from a team as a code owner June 7, 2023 10:18
@pmalek pmalek self-assigned this Jun 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -15.35 ⚠️

Comparison is base (91d5885) 52.77% compared to head (b330dd7) 37.42%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #342       +/-   ##
===========================================
- Coverage   52.77%   37.42%   -15.35%     
===========================================
  Files          69       69               
  Lines        5095     5095               
===========================================
- Hits         2689     1907      -782     
- Misses       1832     2858     +1026     
+ Partials      574      330      -244     
Flag Coverage Δ
2.1.4 ?
2.2.1.3 ?
2.2.2 ?
2.3.3 ?
2.3.3.4 ?
2.4.1 ?
2.4.1.3 ?
2.5.1.2 ?
2.5.2 ?
2.6.1 ?
2.6.1.0 ?
2.7.2 ?
2.7.2.0 ?
2.8.3 ?
2.8.4.0 ?
3.0.2 ?
3.0.2.0 ?
3.1.1 ?
3.1.1.3 ?
3.2.2 ?
3.2.2.1 ?
community 37.42% <ø> (-0.55%) ⬇️
enterprise ?
integration 37.42% <ø> (-15.35%) ⬇️
nightly 37.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nishant95
Copy link
Contributor

Please use #343 instead.

@pmalek pmalek closed this Jun 7, 2023
@pmalek pmalek deleted the remove-unneeded-version-constraint-in-Test_FillPluginsDefaults_Acme branch June 7, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants