Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add team-deck to CODEOWNERS #340

Merged
merged 3 commits into from
Jun 7, 2023
Merged

chore: add team-deck to CODEOWNERS #340

merged 3 commits into from
Jun 7, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jun 6, 2023

In the course of #339 I found that while there are team-deck members around during Americas hours, they're not actually allowed to approve go-kong PRs. They probably should be since the library is shared between teams.

Needs a main merge after #339 to silence the linter.

@rainest rainest requested a review from a team as a code owner June 6, 2023 18:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (91d5885) 52.77% compared to head (c41c65b) 52.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   52.77%   52.77%           
=======================================
  Files          69       69           
  Lines        5095     5095           
=======================================
  Hits         2689     2689           
  Misses       1832     1832           
  Partials      574      574           
Flag Coverage Δ
2.1.4 36.29% <ø> (ø)
2.2.1.3 46.77% <ø> (ø)
2.2.2 36.29% <ø> (ø)
2.3.3 36.34% <ø> (ø)
2.3.3.4 47.43% <ø> (ø)
2.4.1 36.42% <ø> (ø)
2.4.1.3 47.51% <ø> (ø)
2.5.1.2 47.51% <ø> (ø)
2.5.2 36.42% <ø> (ø)
2.6.1 36.42% <ø> (ø)
2.6.1.0 47.51% <ø> (ø)
2.7.2 36.42% <ø> (ø)
2.7.2.0 49.04% <ø> (ø)
2.8.3 36.42% <ø> (ø)
2.8.4.0 49.04% <ø> (ø)
3.0.2 35.87% <ø> (ø)
3.0.2.0 49.49% <ø> (ø)
3.1.1 37.36% <ø> (ø)
3.1.1.3 50.99% <ø> (ø)
3.2.2 37.42% <ø> (ø)
3.2.2.1 50.99% <ø> (ø)
community 37.97% <ø> (ø)
enterprise 51.54% <ø> (ø)
integration 52.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add write access for Kong/team-deck and only Github stopped complaining.

@pmalek pmalek enabled auto-merge (squash) June 7, 2023 10:27
@pmalek pmalek merged commit 22da716 into main Jun 7, 2023
@pmalek pmalek deleted the chore/codeowners branch June 7, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants