Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow explicit nulls in config #321

Closed
wants to merge 1 commit into from

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Apr 27, 2023

Allow explicit nulls in configurations to fix #320 .

@randmonkey randmonkey requested a review from a team as a code owner April 27, 2023 07:02
@randmonkey randmonkey force-pushed the not_fill_config_explicit_nulls branch from 47ad988 to b4ccf51 Compare April 27, 2023 07:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (b8f2114) 52.82% compared to head (b4ccf51) 52.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   52.82%   52.86%   +0.03%     
==========================================
  Files          69       69              
  Lines        5077     5081       +4     
==========================================
+ Hits         2682     2686       +4     
  Misses       1817     1817              
  Partials      578      578              
Flag Coverage Δ
2.1.4 36.23% <100.00%> (+0.05%) ⬆️
2.2.1.3 46.74% <100.00%> (+0.04%) ⬆️
2.2.2 36.23% <100.00%> (+0.05%) ⬆️
2.3.3 36.39% <100.00%> (+0.05%) ⬆️
2.3.3.4 47.41% <100.00%> (+0.04%) ⬆️
2.4.1 36.46% <100.00%> (+0.05%) ⬆️
2.4.1.3 47.49% <100.00%> (+0.04%) ⬆️
2.5.1.2 47.49% <100.00%> (+0.04%) ⬆️
2.5.2 36.46% <100.00%> (+0.05%) ⬆️
2.6.1 36.46% <100.00%> (+0.05%) ⬆️
2.6.1.0 47.49% <100.00%> (+0.04%) ⬆️
2.7.2 36.46% <100.00%> (+0.05%) ⬆️
2.7.2.0 49.02% <100.00%> (+0.04%) ⬆️
2.8.3 36.46% <100.00%> (+0.05%) ⬆️
2.8.4.0 49.02% <100.00%> (+0.04%) ⬆️
3.0.2 35.91% <100.00%> (+0.05%) ⬆️
3.0.2.0 49.47% <100.00%> (+0.03%) ⬆️
3.1.1 37.41% <100.00%> (+0.04%) ⬆️
3.1.1.3 51.07% <100.00%> (+0.03%) ⬆️
3.2.2 37.47% <100.00%> (+0.04%) ⬆️
3.2.2.1 51.07% <100.00%> (+0.03%) ⬆️
community 38.02% <100.00%> (+0.04%) ⬆️
enterprise 51.62% <100.00%> (+0.03%) ⬆️
enterprise-nightly 51.07% <100.00%> (?)
integration 52.86% <100.00%> (+0.03%) ⬆️
nightly 37.47% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/utils.go 88.16% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mflendrich
Copy link
Contributor

Not planned - as explained in #320 (comment)

@mflendrich mflendrich closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve explicit nulls in plugin configs
3 participants