-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh security recommendations #7173
Draft
lahabana
wants to merge
5
commits into
Kong:main
Choose a base branch
from
lahabana:meshSecurityRecommendations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charly Molter <[email protected]>
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lahabana
force-pushed
the
meshSecurityRecommendations
branch
from
April 4, 2024 16:54
ebfb52b
to
34a0d7b
Compare
Signed-off-by: Charly Molter <[email protected]>
@fabianrbz I guess this is due to my cross link to Konnect's docs. Do you know how I should write this to make the test pass? |
@fabianrbz I ran this locally and all tests passed. What could be the issue? |
The issue is that it comes from a fork, and the VITE_PORTAL_API_URL doesn't exist in the forks env. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Preview link:
Checklist
For example, if this change is for an upcoming 3.6 release, enclose your content in
{% if_version gte:3.6.x %} <content> {% endif_version %}
tags (orif_plugin_version
tags for plugins).Use any of the following keys:
gte:<version>
- greater than or equal to a specific versionlte:<version>
- less than or equal to a specific versioneq:<version>
- exactly equal to a specific versionYou can do the same for older versions.