chore(comment): add a Dockerfile comment so upgrades don't accidental…

…ly move into official images (#529)
Kong · Dec 17, 2021 · 4896c55 · 4896c55
1 parent 395889c
commit 4896c55
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/alpine/Dockerfile b/alpine/Dockerfile
@@ -29,6 +29,7 @@ RUN set -eux; \
       && echo "$KONG_SHA256  /tmp/kong.tar.gz" | sha256sum -c - \
       && apk del .build-deps; \
     else \
+      # this needs to stay inside this "else" block so that it does not become part of the "official images" builds (https://github.com/docker-library/official-images/pull/11532#issuecomment-996219700)
       apk upgrade; \
     fi; \
     mkdir /kong \

diff --git a/centos/Dockerfile b/centos/Dockerfile
@@ -19,6 +19,7 @@ RUN set -ex; \
       curl -fL https://download.konghq.com/gateway-${KONG_VERSION%%.*}.x-centos-8/Packages/k/kong-$KONG_VERSION.el8.amd64.rpm -o /tmp/kong.rpm \
       && echo "$KONG_SHA256  /tmp/kong.rpm" | sha256sum -c -; \
     else \
+      # this needs to stay inside this "else" block so that it does not become part of the "official images" builds (https://github.com/docker-library/official-images/pull/11532#issuecomment-996219700)
       yum update -y \
       && yum upgrade -y ; \
     fi; \

diff --git a/ubuntu/Dockerfile b/ubuntu/Dockerfile
@@ -21,6 +21,7 @@ RUN set -ex \
       && apt-get purge -y curl \
       && echo "$KONG_SHA256  /tmp/kong.deb" | sha256sum -c -; \
     else \
+      # this needs to stay inside this "else" block so that it does not become part of the "official images" builds (https://github.com/docker-library/official-images/pull/11532#issuecomment-996219700)
       apt-get upgrade -y ; \
     fi; \
     apt-get install -y --no-install-recommends unzip git \