Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Drop support of PHP 5.6 #547

Merged
merged 1 commit into from
Jan 8, 2018
Merged

[1.x] Drop support of PHP 5.6 #547

merged 1 commit into from
Jan 8, 2018

Conversation

akerouanton
Copy link
Contributor

@akerouanton akerouanton commented Jan 5, 2018 •
edited
Loading

Related to #497.

@akerouanton akerouanton added this to the v1.0 milestone Jan 5, 2018
@nicolasmure nicolasmure merged commit b153cc5 into KnpLabs:1.x Jan 8, 2018
@akerouanton akerouanton deleted the drop-php-56 branch January 8, 2018 22:58
@nicolasmure
Copy link
Contributor

@NiR- shouldn't the php version in composer.json be bumped to >=7.0 too ?

@akerouanton
Copy link
Contributor Author

Woops, indeed I forgot it... :D Can you push a fix to develop?

@nicolasmure
Copy link
Contributor

Yes :)

@nicolasmure nicolasmure mentioned this pull request Jan 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasmure nicolasmure nicolasmure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akerouanton @nicolasmure