[RFR] [1.x] OpenCloud adapter rewrite #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, tests are broken because of the Filesystem not handling the new implementation of the adapters (ie exceptions and void return functions). |
nicolasmure
changed the title
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
from
1eb1a05 to
e85f7d6
Compare
12 tasks
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
2 times, most recently
from
27c0026 to
a6cfe19
Compare
nicolasmure
changed the title
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
2 times, most recently
from
abb35bc to
ed4c2bc
Compare
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
from
0787873 to
1f9e717
Compare
akerouanton
suggested changes
Feb 8, 2018
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
2 times, most recently
from
c3f44df to
9f3eb09
Compare
nicolasmure
changed the title
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
from
9f3eb09 to
545cc7d
Compare
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
5 times, most recently
from
2a7b48a to
34aa848
Compare
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
from
34aa848 to
03f6a04
Compare
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
from
03f6a04 to
bf7ef73
Compare
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
5 times, most recently
from
f8024c3 to
b9e17da
Compare
akerouanton
reviewed
Jun 7, 2019
| - php: '7.1' | ||
| - php: '7.2' | ||
| - php: '7.3' | ||
| - php: '7.1.29' |
There was a problem hiding this comment.
Why do we require specific patch versions? IMHO we should always build using last patch version.
There was a problem hiding this comment.
Travis had issues with curl on its minor php versions. I tried to manually download a root certificate and to set a php option to point to this certificate but there was no changes.
Secifying the latest patch fixed the issue (see commit 9224c74 ).
I can try to always use the latest version instead of hardcoding it.
akerouanton
reviewed
Jun 7, 2019
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
from
b9e17da to
35dd94e
Compare
7 tasks
akerouanton
approved these changes
Jun 28, 2019
nicolasmure
force-pushed
the
feature/opencloud-adapter-exceptions
branch
from
986c0f7 to
7c67d68
Compare
|
Very nice job guys ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #497. Also applies propositions from #521.
Replaces the
rackspace/php-opencloudSDK by thephp-opencloud/openstackSDK.TODO
Prevents merging
@TODOTodo when ready to merge