Update AwsS3.php #395
Closed
Update AwsS3.php #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is an exception on put object it should be returned instead of masking it returning false.
|
@jjborie thank you for reporting that. It is something I am working on at the moment in https://github.com/KnpLabs/Gaufrette/tree/feature/exceptions. You can take a look and advice me there if you notice anything. |
|
This patch is not ideal: the exception should be passed as previous and not to sprintf. Also I think you made an error because the stacktrace is printed in the middle of the sentence, that does not make sense. Anyway, thank you for pointing out this issue to us. I've opened an issue to remind us to fix this bad error handling scheme for v1.0 (see #497). Sorry for the first email with bad tone, it was an error :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an exception on put object it should be returned instead of masking it returning false.
This change is