stop blocking ESPHome #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syssi
added a commit
to syssi/esphome-victron-vedirect
that referenced
this pull request
Nov 21, 2023
This reverts commit 3d6d245.
wozz
added a commit
to wozz/VictronMPPT-ESPHOME
that referenced
this pull request
Nov 21, 2023
This reverts commit 3d6d245.
Merged
syssi
added a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to rely on the ESPHome event loop instead of waiting to read the entire serial buffer at a time.
It seems to work in the sense that it no longer throws warnings about blocking esphome too long, however now it randomly throws errors like:
[D][victron:1024]: Unhandled property: HS 0. which seems like something is getting corrupted, which wasn't before. Maybe increasing the uart buffer would help.fixes #132