Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.96.8 AA turrets #838

Open
wants to merge 10 commits into
base: v0.96.8
Choose a base branch
from

Conversation

nicoman35
Copy link

@nicoman35 nicoman35 commented Sep 28, 2020

Q A
Bug fix? no
New feature? yes
Needs wipe? no

Description:

Adds opFor AA turrets, when custom or apex presets are played

Content:

  • Content part

Successfully tested on:

  • Local MP
  • Dedicated MP

Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall thanks for your willingness to contribute to the project. 👍

I've added you some hints and suggestions for your code.

Please make sure to either delete the content part paragraph in the PR description or fill it with e.g. "Function X added", "XY Variable added to presets", etc.
Refer to the comments in the PR template.
[ ] is by the way an unchecked checkbox and [x] a checked one (which are also clickable in the PR description)

Concerning the checked "local MP" test, I highly doubt this was actually done with the .8 version of the framework due to the deprecated global variables. Please make sure you test the actual code you want to contribute and pledge for working without issues in normal gameplay.

We're currently slightly reorganize and refactor the framework concerning variable naming conventions and going away from these old and ugly endless loops. Replacing them with event handling or FSMs. And also maintaining a proper functions library. Maybe you want to have a look at implementing your idea without an endless loop to suit the way we want to refactor the current code base bit by bit.
Feel free to ask questions about these things in the general scripting channel of our Discord.

Don't feel discouraged by the amount of review comments, it's meant as help and a possible way to improve your coding in SQF in general.
Have fun getting your idea into code and see it running in the end.

I'm looking forward seeing for your next iteration on this. :)

Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
Missionframework/scripts/server/ai/AA_turret_manager.sqf Outdated Show resolved Hide resolved
@Wyqer Wyqer added the enhancement New feature or request label Sep 28, 2020
@Wyqer Wyqer added this to the v0.96.8 milestone Sep 28, 2020
@Wyqer
Copy link
Member

Wyqer commented Sep 28, 2020

Also kind of connected to #781

@Wyqer
Copy link
Member

Wyqer commented Sep 29, 2020

Right down below you're able to write normal comments.
As said, let's not discuss something about event driven in a comment thread with the topic of declaring private variables outside of a loop. It might seem picky, but that way it stays organized and easier for keeping an overview.
Basically I guess this would still be the best, as mentioned in the first comment:

We're currently slightly reorganize and refactor the framework concerning variable naming conventions and going away from these old and ugly endless loops. Replacing them with event handling or FSMs. And also maintaining a proper functions library. Maybe you want to have a look at implementing your idea without an endless loop to suit the way we want to refactor the current code base bit by bit.
Feel free to ask questions about these things in the general scripting channel of our Discord.

- AA manager updated with all demanded corrections
- added missing AA spawn point function
- fixed a deprecated variable in various mission files
@nicoman35 nicoman35 requested a review from Wyqer October 1, 2020 16:28
Apricot-ale added a commit to Apricot-ale/KP-Liberation-APR that referenced this pull request Feb 28, 2023
Apricot-ale added a commit to Apricot-ale/KP-Liberation-APR that referenced this pull request Mar 2, 2023
Apricot-ale added a commit to Apricot-ale/KP-Liberation-APR that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants